Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Windows application manifests for all executable projects #756

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Generate Windows application manifests for all executable projects #756

merged 1 commit into from
Jun 22, 2022

Conversation

mjcheetham
Copy link
Collaborator

Automatically generate the correct application manifest for Windows executable projects that we produce. The manifests are required on Windows systems newer then Windows 8 to correctly access versioning APIs that will otherwise always report "Windows 8", even on later versions.

The manifest we generate states we are compatible with all versions of Windows from 7 to 11 (inclusive).

Example manifest:

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<assembly manifestVersion="1.0" xmlns="urn:schemas-microsoft-com:asm.v1">
  <assemblyIdentity version="2.0.770.50703" name="git-credential-manager-core"></assemblyIdentity>
  <compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1">
    <application>
      <!-- Windows 10 and Windows 11 -->
      <supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}"></supportedOS>
      <!-- Windows 8.1 -->
      <supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"></supportedOS>
      <!-- Windows 8 -->
      <supportedOS Id="{4a2f28e3-53b9-4441-ba9c-d69d4a4a6e38}"></supportedOS>
      <!-- Windows 7 -->
      <supportedOS Id="{35138b9a-5d96-4fbd-8e2d-a2440225f93a}"></supportedOS>
    </application>
  </compatibility>
</assembly>

Fixes #749

@mjcheetham mjcheetham requested a review from ldennington June 21, 2022 12:38
ldennington
ldennington approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@ldennington ldennington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mjcheetham
windows: generate app manifests for all exe projects
dab7930 
Automatically generate the correct application manifest for Windows
executable projects that we produce. The manifests are required on
Windows systems newer than Windows 8 to correctly access versioning
APIs that will otherwise always report "Windows 8", even on later
versions.

The manifest we generate states we are compatible with all versions of
Windows from 7 to 11 (inclusive).
@mjcheetham mjcheetham merged commit a9d78c1 into git-ecosystem:main Jun 22, 2022
@mjcheetham mjcheetham deleted the win-manifest branch June 22, 2022 14:59
@mjcheetham mjcheetham mentioned this pull request Jun 22, 2022
Closed
@ldennington ldennington mentioned this pull request Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldennington ldennington ldennington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mjcheetham @ldennington